test: Create unit tests for react components is packages/ui/components/navigation#10698
test: Create unit tests for react components is packages/ui/components/navigation#10698hariombalhara merged 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 47 of 123 screens tested: view and approve differences detected. Last updated for commit 810e79e. This comment will update as new commits are pushed. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 120 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/23/2023 01:48:27pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b124501 Started: 08/23/2023 01:46:59pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.79% (7)7 / 251 runsfailed over last 7 days |
96.81% (243)243 / 251 runsflaked over last 7 days |
| expect(name).toBeInTheDocument(); | ||
| expect(tabLabelElement).toHaveAttribute("href", tab.href); | ||
|
|
||
| const spanSibling = name.querySelector("span"); |
There was a problem hiding this comment.
span seems to be implementation detail. User doesn't see a span, he would see the content in it.
We should check what that span shows to user.
There was a problem hiding this comment.
Hi @hariombalhara That span tag doesn't have any content, please take a look here:
There was a problem hiding this comment.
@gitstart-calcom Then why are we checking for span tag. What I meant was that we should test for what a user sees. If he can't see the span(it has no content), then why are we testing its presence
There was a problem hiding this comment.
Makes sense, we have updated the test now
hariombalhara
left a comment
There was a problem hiding this comment.
Thanks @gitstart-calcom. Left some comments.
|
Hi @hariombalhara we made the requested changes, please take a look 😄 |
Testing