Skip to content

feat: 30 day email digest#10627

Closed
rkreddy99 wants to merge 2 commits intocalcom:mainfrom
rkreddy99:rkreddy99/cal-2127
Closed

feat: 30 day email digest#10627
rkreddy99 wants to merge 2 commits intocalcom:mainfrom
rkreddy99:rkreddy99/cal-2127

Conversation

@rkreddy99
Copy link
Copy Markdown
Contributor

@rkreddy99 rkreddy99 commented Aug 7, 2023

What does this PR do?

This pr creates a new feature for showing 30day summary of an user.
draft pr displaying the info that will be shown, styling is also left. PFA image below

check this for more info on calcs #10627 (comment)

Fixes #10026

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Login
  • navigate to insights
  • click on GET 30 day email digest button on top left.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 8:21am

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 7, 2023

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email Low priority Created by Linear-GitHub Sync ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Aug 7, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2023

Thank you for following the naming conventions! 🙏

@rkreddy99
Copy link
Copy Markdown
Contributor Author

will replace the attended x events with booked x events

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@rkreddy99
Copy link
Copy Markdown
Contributor Author

Checks for hosted, attended, payments, unique attendees (by email), unique (timeZones) can display flags here like grouped avatars, would be cool, top events by bokings

a booking is considered to be hosted if the

  • user is the user for the booking
  • user is present in attendees and eventType has user in owners or users field, this check is done by checking the user emails in attendees table.

remaining are considered to be attended events (/booked events)

payments are considered to be successfull if booking.paid is true and payment is success and not refunded.

number of bokings is straightforward, check bookings for hosted events.

these calcs are present in https://github.com/calcom/cal.com/pull/10627/files#diff-6d0267b35107118d2b6a7edc76233a9f13ce89b7aaf2e99b82a9bfa55bbc44b7

@rkreddy99
Copy link
Copy Markdown
Contributor Author

rkreddy99 commented Aug 7, 2023

todo if this solves the issue

styles in email
cron scheduler
graphs (maybe) - display 2 lines (one for no of bookings and one for booked duration per day for the last 30 days), something like this - https://apexcharts.com/javascript-chart-demos/area-charts/spline/

@rkreddy99
Copy link
Copy Markdown
Contributor Author

cc @PeerRich

@rkreddy99 rkreddy99 marked this pull request as ready for review August 15, 2023 05:05
@rkreddy99
Copy link
Copy Markdown
Contributor Author

@PeerRich @baileypumfleet @CarinaWolli

Can you guys confirm whether this is the data that has to be shown in the digest email?

@CarinaWolli
Copy link
Copy Markdown
Member

I am not sure what we would want to show here, maybe @ciaranha could give some input, also some design suggestions for the email would be good

@CarinaWolli CarinaWolli mentioned this pull request Aug 23, 2023
2 tasks
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Sep 23, 2023
@PeerRich
Copy link
Copy Markdown
Member

we merged #10621 instead. thank you for contributing tho!

@PeerRich PeerRich closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💎 Bounty A bounty on Algora.io emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email ✨ feature New feature or request Low priority Created by Linear-GitHub Sync Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2127] feature: 30 day email digest

4 participants