fix: onboarding nits#25248
Merged
sean-brydon merged 11 commits intocalcom:sean/onboarding-v3-illustrations-animationsfrom Nov 18, 2025
Merged
fix: onboarding nits#25248sean-brydon merged 11 commits intocalcom:sean/onboarding-v3-illustrations-animationsfrom
sean-brydon merged 11 commits intocalcom:sean/onboarding-v3-illustrations-animationsfrom
Conversation
|
|
|
@pqoqubbw is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/ui/components/form/inputs/TextField.tsx">
<violation number="1" location="packages/ui/components/form/inputs/TextField.tsx:204">
When the trailing addon is clicked, the consumer-supplied onClickAddon handler is invoked without the MouseEvent, so any code that inspects the event now breaks. Pass the received event through to preserve the handler contract.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Contributor
|
/tip 50 @pqoqubbw |
|
@pqoqubbw: You've been awarded a $50 by Cal.com, Inc.! 👉 Complete your Algora onboarding to collect the tip. |
bc080af
into
calcom:sean/onboarding-v3-illustrations-animations
8 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
onboarding fixes
CleanShot.2025-11-18.at.12.14.05.mp4
CleanShot.2025-11-18.at.12.14.15.mp4
CleanShot.2025-11-18.at.12.57.53.mp4
CleanShot.2025-11-18.at.12.58.05.mp4
CleanShot.2025-11-18.at.1.17.48.mp4
CleanShot.2025-11-18.at.1.17.26.mp4
CleanShot.2025-11-18.at.2.16.47.mp4
CleanShot.2025-11-18.at.2.16.23.mp4
i like this update, but wdyt?
CleanShot.2025-11-18.at.3.06.15.mp4
CleanShot.2025-11-18.at.3.05.41.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Polished the onboarding UI to prevent text overflow and accidental focus, and improved input usability by focusing the field when an addon is clicked.
Written for commit 2c4716e. Summary will update automatically on new commits.