Type fixes

joeauyeung · joeauyeung · commit 7104dbd1c3b4 · 2025-07-18T15:54:43.000-04:00
diff --git a/apps/web/lib/__tests__/getTeamMemberEmailFromCrm.test.ts b/apps/web/lib/__tests__/getTeamMemberEmailFromCrm.test.ts
@@ -45,9 +45,9 @@ function mockBookingFormHandler({
   vi.mocked(bookingFormHandlers.salesforce).mockImplementation(
     (_bookerEmail, _attributeRoutingConfig, _eventTypeId) => {
       if (_bookerEmail === bookerEmail) {
-        return Promise.resolve({ email: teamMemberEmail, recordType: null });
+        return Promise.resolve({ email: teamMemberEmail, recordType: null, recordId: null });
       }
-      return Promise.resolve({ email: null, recordType: null });
+      return Promise.resolve({ email: null, recordType: null, recordId: null });
     }
   );
 }
diff --git a/packages/app-store/routing-forms/appBookingFormHandler.ts b/packages/app-store/routing-forms/appBookingFormHandler.ts
@@ -5,7 +5,7 @@ type AppBookingFormHandler = (
   attendeeEmail: string,
   attributeRoutingConfig: AttributeRoutingConfig,
   eventTypeId: number
-) => Promise<{ email: string | null; recordType: string | null }>;
+) => Promise<{ email: string | null; recordType: string | null; recordId: string | null }>;
 
 const appBookingFormHandler: Record<string, AppBookingFormHandler> = {
   salesforce: routingFormBookingFormHandler,
diff --git a/packages/lib/server/getTeamMemberEmailFromCrm.ts b/packages/lib/server/getTeamMemberEmailFromCrm.ts
@@ -164,7 +164,7 @@ async function getTeamMemberEmailUsingRoutingFormHandler({
   attributeRoutingConfig: AttributeRoutingConfig | null;
   crmAppSlug: string;
 }) {
-  const nullReturnValue = { email: null, skipContactOwner: false, recordType: "" };
+  const nullReturnValue = { email: null, skipContactOwner: false, recordType: "", recordId: "" };
 
   if (!attributeRoutingConfig) return nullReturnValue;
 
@@ -176,7 +176,11 @@ async function getTeamMemberEmailUsingRoutingFormHandler({
   const appHandler = appBookingFormHandler[crmAppSlug];
   if (!appHandler) return nullReturnValue;
 
-  const { email: userEmail, recordType } = await appHandler(bookerEmail, attributeRoutingConfig, eventTypeId);
+  const {
+    email: userEmail,
+    recordType,
+    recordId,
+  } = await appHandler(bookerEmail, attributeRoutingConfig, eventTypeId);
 
   if (!userEmail) return nullReturnValue;
 
@@ -185,7 +189,7 @@ async function getTeamMemberEmailUsingRoutingFormHandler({
 
   if (!userQuery) return nullReturnValue;
 
-  return { ...nullReturnValue, email: userEmail, recordType };
+  return { ...nullReturnValue, email: userEmail, recordType, recordId };
 }
 
 async function getTeamMemberEmailForResponseOrContact({

Original file line number	Diff line number	Diff line change
`@@ -45,9 +45,9 @@ function mockBookingFormHandler({`
`45`	`45`	`vi.mocked(bookingFormHandlers.salesforce).mockImplementation(`
`46`	`46`	`(_bookerEmail, _attributeRoutingConfig, _eventTypeId) => {`
`47`	`47`	`if (_bookerEmail === bookerEmail) {`
`48`		`- return Promise.resolve({ email: teamMemberEmail, recordType: null });`
	`48`	`+ return Promise.resolve({ email: teamMemberEmail, recordType: null, recordId: null });`
`49`	`49`	`}`
`50`		`- return Promise.resolve({ email: null, recordType: null });`
	`50`	`+ return Promise.resolve({ email: null, recordType: null, recordId: null });`
`51`	`51`	`}`
`52`	`52`	`);`
`53`	`53`	`}`