fix usePermission hook

sean-brydon · sean-brydon · commit 7055b1088a44 · 2025-07-28T11:12:17.000+01:00
diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/__tests__/usePermissions.test.ts b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/__tests__/usePermissions.test.ts
@@ -44,5 +44,17 @@ describe("usePermissions", () => {
 
       expect(getResourcePermissionLevel("eventType", permissions)).toBe("all");
     });
+
+    it("should return 'all' for resource with manage permission", () => {
+      const permissions = ["eventType.manage"];
+
+      expect(getResourcePermissionLevel("eventType", permissions)).toBe("all");
+    });
+
+    it("should return 'all' for resource with manage permission even if other permissions are missing", () => {
+      const permissions = ["eventType.manage", "eventType.read"]; // Has manage and read, but missing create, update, delete
+
+      expect(getResourcePermissionLevel("eventType", permissions)).toBe("all");
+    });
   });
 });
diff --git a/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/usePermissions.ts b/apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/usePermissions.ts
@@ -51,14 +51,20 @@ export function usePermissions(): UsePermissionsReturn {
       return "all";
     }
 
-    // Filter out internal keys like _resource when checking permissions
-    const allResourcePerms = Object.keys(resourceConfig)
-      .filter((action) => !action.startsWith("_"))
+    // Check if user has manage permission for this resource
+    const hasManagePermission = permissions.includes(`${resource}.manage`);
+    if (hasManagePermission) {
+      return "all";
+    }
+
+    // Filter out internal keys like _resource and manage when checking for individual permissions
+    const crudPermissions = Object.keys(resourceConfig)
+      .filter((action) => !action.startsWith("_") && action !== "manage")
       .map((action) => `${resource}.${action}`);
-    const hasAllPerms = allResourcePerms.every((p) => permissions.includes(p));
+    const hasAllCrudPerms = crudPermissions.every((p) => permissions.includes(p));
     const hasReadPerm = permissions.includes(`${resource}.${CrudAction.Read}`);
 
-    if (hasAllPerms) return "all";
+    if (hasAllCrudPerms) return "all";
     if (hasReadPerm) return "read";
     return "none";
   };
