perf: optimize analytics app imports to avoid loading entire app store

devin-ai-integration[bot] · keithwillcode · devin-ai-integration[bot] · commit 229d8f1b89b6 · 2025-08-26T19:22:17.000Z
- Add analytics service generation to app-store-cli build process - Generate analytics.services.generated.ts with only analytics apps (dub) - Update getAnalytics.ts to use AnalyticsServiceMap instead of full appStore - Add NEXT_PUBLIC_IS_E2E to turbo.json globalEnv for generated files - Reduces import footprint from 100+ apps to only analytics apps with AnalyticsService - Follows same pattern as calendar services optimization from PR #22450 Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
diff --git a/packages/app-store-cli/src/build.ts b/packages/app-store-cli/src/build.ts
@@ -378,6 +378,43 @@ function generateFiles() {
     calendarOutput.push(...calendarServices);
   }
 
+  const analyticsOutput = [];
+  const analyticsServices = getExportedObject(
+    "AnalyticsServiceMap",
+    {
+      importConfig: {
+        fileToBeImported: "lib/AnalyticsService.ts",
+        importName: "default",
+      },
+      lazyImport: true,
+    },
+    (app: App) => {
+      const hasAnalyticsService = fs.existsSync(
+        path.join(APP_STORE_PATH, app.path, "lib/AnalyticsService.ts")
+      );
+      return hasAnalyticsService;
+    }
+  );
+
+  const analyticsExportLineIndex = analyticsServices.findIndex((line) =>
+    line.startsWith("export const AnalyticsServiceMap")
+  );
+  if (analyticsExportLineIndex !== -1) {
+    const exportLine = analyticsServices[analyticsExportLineIndex];
+    const objectContent = analyticsServices.slice(analyticsExportLineIndex + 1, -1);
+
+    analyticsOutput.push(
+      exportLine.replace(
+        "export const AnalyticsServiceMap = {",
+        "export const AnalyticsServiceMap = process.env.NEXT_PUBLIC_IS_E2E ? {} : {"
+      ),
+      ...objectContent,
+      "};"
+    );
+  } else {
+    analyticsOutput.push(...analyticsServices);
+  }
+
   const banner = `/**
     This file is autogenerated using the command \`yarn app-store:build --watch\`.
     Don't modify this file manually.
@@ -392,6 +429,7 @@ function generateFiles() {
     ["bookerApps.metadata.generated.ts", bookerMetadataOutput],
     ["crm.apps.generated.ts", crmOutput],
     ["calendar.services.generated.ts", calendarOutput],
+    ["analytics.services.generated.ts", analyticsOutput],
   ];
   filesToGenerate.forEach(([fileName, output]) => {
     fs.writeFileSync(`${APP_STORE_PATH}/${fileName}`, formatOutput(`${banner}${output.join("\n")}`));
diff --git a/packages/app-store/_utils/getAnalytics.ts b/packages/app-store/_utils/getAnalytics.ts
@@ -2,7 +2,7 @@ import logger from "@calcom/lib/logger";
 import type { AnalyticsService, AnalyticsServiceClass } from "@calcom/types/AnalyticsService";
 import type { CredentialPayload } from "@calcom/types/Credential";
 
-import appStore from "..";
+import { AnalyticsServiceMap } from "../analytics.services.generated";
 
 const log = logger.getSubLogger({ prefix: ["AnalyticsManager"] });
 
@@ -30,14 +30,15 @@ export const getAnalyticsService = async ({
 
   const analyticsName = analyticsType.split("_")[0];
 
-  const analyticsAppImportFn = appStore[analyticsName as keyof typeof appStore];
+  const analyticsAppImportFn = AnalyticsServiceMap[analyticsName as keyof typeof AnalyticsServiceMap];
 
   if (!analyticsAppImportFn) {
     log.warn(`analytics app not implemented`);
     return null;
   }
 
-  const analyticsApp = await analyticsAppImportFn();
+  const analyticsAppModule = await analyticsAppImportFn;
+  const analyticsApp = { lib: { AnalyticsService: analyticsAppModule.default } };
 
   if (!isAnalyticsService(analyticsApp)) {
     log.warn(`Analytics is not implemented`);
diff --git a/packages/app-store/analytics.services.generated.ts b/packages/app-store/analytics.services.generated.ts
@@ -0,0 +1,9 @@
+/**
+    This file is autogenerated using the command `yarn app-store:build --watch`.
+    Don't modify this file manually.
+**/
+export const AnalyticsServiceMap = process.env.NEXT_PUBLIC_IS_E2E
+  ? {}
+  : {
+      dub: import("./dub/lib/AnalyticsService"),
+    };
diff --git a/turbo.json b/turbo.json
@@ -86,6 +86,7 @@
     "IFFY_API_KEY",
     "INTEGRATION_TEST_MODE",
     "IS_E2E",
+    "NEXT_PUBLIC_IS_E2E",
     "INTERCOM_SECRET",
     "INTERCOM_SECRET",
     "INSIGHTS_DATABASE_URL",
