An empty array is truthy, [0] potentially isn't

emrysal · emrysal · commit 1392a4747645 · 2023-03-27T23:06:07.000+02:00
diff --git a/packages/features/bookings/lib/handleCancelBooking.ts b/packages/features/bookings/lib/handleCancelBooking.ts
@@ -494,7 +494,7 @@ async function handler(req: CustomRequest) {
     bookingToDelete.user.credentials
       .filter((credential) => credential.type.endsWith("_video"))
       .forEach((credential) => {
-        const uidToDelete = bookingToDelete?.references?.[0].uid ?? bookingToDelete.uid;
+        const uidToDelete = bookingToDelete?.references?.[0]?.uid ?? bookingToDelete.uid;
         apiDeletes.push(deleteMeeting(credential, uidToDelete));
       });
   }

Original file line number	Diff line number	Diff line change
`@@ -494,7 +494,7 @@ async function handler(req: CustomRequest) {`
`494`	`494`	`bookingToDelete.user.credentials`
`495`	`495`	`.filter((credential) => credential.type.endsWith("_video"))`
`496`	`496`	`.forEach((credential) => {`
`497`		`- const uidToDelete = bookingToDelete?.references?.[0].uid ?? bookingToDelete.uid;`
	`497`	`+ const uidToDelete = bookingToDelete?.references?.[0]?.uid ?? bookingToDelete.uid;`
`498`	`498`	`apiDeletes.push(deleteMeeting(credential, uidToDelete));`
`499`	`499`	`});`
`500`	`500`	`}`