Fix defaultName deprecation warning on symfony/console 6.1#2107
Merged
MasterOdin merged 5 commits into0.xfrom Oct 3, 2022
Merged
Fix defaultName deprecation warning on symfony/console 6.1#2107MasterOdin merged 5 commits into0.xfrom
MasterOdin merged 5 commits into0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2104
symfony/consolehas changed the mechanism in which command names should be declared, switching from using$defaultNamestatic class parameter, to an attribute.This deprecation was introduced in 6.1, but the
AsNameattribute has existed since 5.4. From my testing, it looks like this should work fine for users on older symfony versions with newer PHP versions, as the usage here was purely throughReflectionClass::getAttributes.