Fix CI failures: rector and phpstan issues #19184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply rector fixes: - Remove @return void from __clone(), __construct(), __destruct() magic methods - Combine nested if statements in PluginAssetsTrait Fix PHPStan issue: - Remove redundant `if (!$copy)` check in PluginAssetsTrait::_process() that was always true after the preceding `if ($copy) { ... continue; }` block
a1fa0bd to
19265d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@return voidfrom magic methods (__clone,__construct,__destruct)if (!$copy)check that was always trueI also fixed up the broken constraint.