Fix limitControl() to keep current filters when switching the limit s… #18985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b0c36c to
36723f0
Compare
36723f0 to
c621b5e
Compare
ADmad
reviewed
Oct 23, 2025
src/View/Helper/PaginatorHelper.php
Outdated
| } | ||
|
|
||
| $url = $this->_View->getRequest()->getPath(); | ||
| $out = $this->Form->create(null, ['type' => 'get', 'url' => $url]); |
Member
There was a problem hiding this comment.
The form URL defaults to current URL, so we can skip setting $url.
Member
Author
There was a problem hiding this comment.
If we remove the key, it generates the long ones again:
/posts?filter%5Bdate%5D%5Bstart%5D=2024-01-01&filter%5Bdate%5D%5Bend%5D=2024-12-31&filter%5Bstatus%5D=active
which are somewhat overkill, since it skips the query string anyway.
Using 'url' => [] seems the best way, since it defaults to the current route URL.
markstory
reviewed
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ize.
The problem is clear: it doesnt magically merge existing ones in the URL with the ones Form posted.
So
'action' => '/batches?owner=billy&expected=1&page=1'is actually always'action' => '/batches'.Resolves limitControl() when filters (e.g. Search plugin) are applied, but then would be resettet as a GET form result without all query string filters as hidden fields would make them removed.