Merged
Conversation
Co-authored-by: Arthur Lacote <arthur.lcte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes scikit-learn#33113
The bug was detected by the test from this PR: scikit-learn#32193
What does this implement/fix? Explain your changes.
First, I considered removing the erroneous
break(see the issue).But then I benchmarked
_any_isnan_axis0, and I noticed it was not much faster than justnp.isnan(...).any(axis=0)which anyway is incomparably fast compared to fitting a tree. So I propose to just remove this function.AI usage disclosure
I used AI assistance for finding where the bug detected by my test came from.
Other comments
I didn't add a regression test as it's already covered by scikit-learn#32193, but I can add one if needed.