Skip to content

Update to Cake 5.0 and .NET 9#195

Merged
devlead merged 2 commits into
cake-contrib:developfrom
pascalberger:feature/cake-5
Dec 11, 2024
Merged

Update to Cake 5.0 and .NET 9#195
devlead merged 2 commits into
cake-contrib:developfrom
pascalberger:feature/cake-5

Conversation

@pascalberger

@pascalberger pascalberger commented Nov 22, 2024

Copy link
Copy Markdown
Member

Updates to support Cake 5.0:

  • Builds against Cake 5.0
  • Multi-Targets additionally .NET 9 and removes support for .NET 6 & .NET 7
  • Updates build to Cake 5.0

Fixes #193
Fixes #194

@devlead devlead force-pushed the feature/cake-5 branch 2 times, most recently from 204870d to c063d97 Compare November 23, 2024 21:56
@pascalberger

pascalberger commented Dec 3, 2024

Copy link
Copy Markdown
Member Author

Tests are currently failing. Actual exception is:

System.TypeInitializationException: The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception.
 ---> System.DllNotFoundException: Unable to load DLL 'git2-a418d9d' or one of its dependencies: The specified module could not be found. (0x8007007E)
   at LibGit2Sharp.Core.NativeMethods.git_libgit2_init()
   at LibGit2Sharp.Core.NativeMethods.InitializeNativeLibrary() in /_/LibGit2Sharp/Core/NativeMethods.cs:line 148
   at LibGit2Sharp.Core.NativeMethods.InitializeNativeLibrary() in /_/LibGit2Sharp/Core/NativeMethods.cs:line 144
   at LibGit2Sharp.Core.NativeMethods..cctor() in /_/LibGit2Sharp/Core/NativeMethods.cs:line 54
   --- End of inner exception stack trace ---
   at LibGit2Sharp.Core.NativeMethods.git_repository_init_ext(git_repository*& repository, FilePath path, GitRepositoryInitOptions options)
   at LibGit2Sharp.Core.Proxy.git_repository_init_ext(FilePath workdirPath, FilePath gitdirPath, Boolean isBare) in /_/LibGit2Sharp/Core/Proxy.cs:line 2492
   at LibGit2Sharp.Repository.Init(String path, Boolean isBare) in /_/LibGit2Sharp/Repository.cs:line 498
   at LibGit2Sharp.Repository.Init(String path) in /_/LibGit2Sharp/Repository.cs:line 485
   at Cake.Git.GitAliases.GitInit(ICakeContext context, DirectoryPath initDirectoryPath)
   at Submission#0.GitInit(DirectoryPath initDirectoryPath)
   at Submission#0.<<Initialize>>b__0_3()

@pascalberger

pascalberger commented Dec 3, 2024

Copy link
Copy Markdown
Member Author

Tests are currently failing. Actual exception is:

System.TypeInitializationException: The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception.
 ---> System.DllNotFoundException: Unable to load DLL 'git2-a418d9d' or one of its dependencies: The specified module could not be found. (0x8007007E)
   at LibGit2Sharp.Core.NativeMethods.git_libgit2_init()
   at LibGit2Sharp.Core.NativeMethods.InitializeNativeLibrary() in /_/LibGit2Sharp/Core/NativeMethods.cs:line 148
   at LibGit2Sharp.Core.NativeMethods.InitializeNativeLibrary() in /_/LibGit2Sharp/Core/NativeMethods.cs:line 144
   at LibGit2Sharp.Core.NativeMethods..cctor() in /_/LibGit2Sharp/Core/NativeMethods.cs:line 54
   --- End of inner exception stack trace ---
   at LibGit2Sharp.Core.NativeMethods.git_repository_init_ext(git_repository*& repository, FilePath path, GitRepositoryInitOptions options)
   at LibGit2Sharp.Core.Proxy.git_repository_init_ext(FilePath workdirPath, FilePath gitdirPath, Boolean isBare) in /_/LibGit2Sharp/Core/Proxy.cs:line 2492
   at LibGit2Sharp.Repository.Init(String path, Boolean isBare) in /_/LibGit2Sharp/Repository.cs:line 498
   at LibGit2Sharp.Repository.Init(String path) in /_/LibGit2Sharp/Repository.cs:line 485
   at Cake.Git.GitAliases.GitInit(ICakeContext context, DirectoryPath initDirectoryPath)
   at Submission#0.GitInit(DirectoryPath initDirectoryPath)
   at Submission#0.<<Initialize>>b__0_3()

Runtime files were not packaged correctly. Should be fine now

devlead
devlead approved these changes Dec 11, 2024
View reviewed changes

@devlead devlead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@devlead devlead merged commit 16ad111 into cake-contrib:develop Dec 11, 2024
@pascalberger pascalberger deleted the feature/cake-5 branch December 11, 2024 15:18
@jnoordsij jnoordsij mentioned this pull request Dec 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devlead devlead devlead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to Cake 5.0 Multi-Target .NET 8 & 9

2 participants

@pascalberger @devlead