Skip to content
This repository was archived by the owner on Dec 25, 2023. It is now read-only.

Update MSBuild.StructuredLogger to the latest version#249

Merged
pascalberger merged 1 commit intocake-contrib:developfrom
KirillOsenkov:dev/kirillo/updateBinlog
Dec 4, 2021
Merged

Update MSBuild.StructuredLogger to the latest version#249
pascalberger merged 1 commit intocake-contrib:developfrom
KirillOsenkov:dev/kirillo/updateBinlog

Conversation

@KirillOsenkov
Copy link
Copy Markdown
Contributor

@KirillOsenkov KirillOsenkov commented Sep 1, 2021

This enables reading the latest binlogs produced by recent versions of MSBuild (including the latest version 14).

@KirillOsenkov KirillOsenkov requested a review from a team as a code owner September 1, 2021 17:27
@pascalberger
Copy link
Copy Markdown
Member

pascalberger commented Sep 1, 2021

@KirillOsenkov Thanks for the PR 👍

We kept dependency at 2.0 by design for the moment, to maintain compatibility with all .NET versions Cake supports. Version 2.1 drops support for .NET 4.6 and MsBuild 14 and bumps requirements to .NET 4.7.2 and MsBuild to 15.1.0 which would mean that, while it would support newer binlog formats, it will stop working on these environments.
Note that binlog is only one of the supported formats of this addin (the other is an XML format created by MsBuild.Extension.Pack logger).

I personally can live with this restriction, even if it means that requirements for the addin are higher than what Cake itself requires and removes support for older Visual Studio versions. So maybe we should just bump it, as I haven't heard any different opinion yet.

See #178 for details.

@KirillOsenkov
Copy link
Copy Markdown
Contributor Author

KirillOsenkov commented Sep 1, 2021

I see, thanks for the explanation. Indeed, bringing back MSBuild 14 and .NET 4.6 would require adding a lot of #ifdef and other plumbing, so doubtful it's worth doing. Then your current approach is sensible.

pascalberger
pascalberger approved these changes Dec 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cake 2.0 has removed support for .NET Framework runner and therefore we can update to latest MsBuild.StructuredLogger in this addin

@KirillOsenkov @pascalberger
Update MSBuild.StructuredLogger to the latest version
9607493 
This enables reading the latest binlogs produced by recent versions of MSBuild (including the latest version 14).
@pascalberger pascalberger force-pushed the dev/kirillo/updateBinlog branch from 85f2e99 to 9607493 Compare December 4, 2021 20:39
@pascalberger pascalberger linked an issue Dec 4, 2021 that may be closed by this pull request
Add support for binlog version 9 file format #178
Closed
@pascalberger pascalberger merged commit 1a33793 into cake-contrib:develop Dec 4, 2021
@pascalberger
Copy link
Copy Markdown
Member

pascalberger commented Dec 4, 2021

@KirillOsenkov your changes have been merged, thanks for your contribution 👍

@KirillOsenkov KirillOsenkov deleted the dev/kirillo/updateBinlog branch December 4, 2021 21:50
@pascalberger pascalberger mentioned this pull request Jul 20, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pascalberger pascalberger pascalberger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for binlog version 9 file format

2 participants

@KirillOsenkov @pascalberger