This repository was archived by the owner on Dec 25, 2023. It is now read-only.
(GH-201) Support parsing of errors in MsBuildXmlFileLoggerFormat#199
Merged
pascalberger merged 1 commit intocake-contrib:developfrom Sep 23, 2020
Merged
Conversation
3 tasks
e9a17da to
3f64387
Compare
pascalberger
approved these changes
Sep 23, 2020
Member
pascalberger
left a comment
There was a problem hiding this comment.
@cho-trackman Thank you for your contribution 👍
LGTM. I've added another test case for files containing only errors without warnings. As part of #201 I'll implement parsing of error message also for binary log support.
3f64387 to
ef4f17b
Compare
3 tasks
Member
|
@cho-trackman your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I wanted to annotate our pull requests with build errors but had to make a custom implementation of
XmlFileLoggerLogFileFormat.csto make it work. So here is a PR with my changes.Note that I could not run all tests, because of absolute paths in the log files.
Part of #201