Fixes reporting issues without priority to console#1254
Merged
pascalberger merged 1 commit intocake-contrib:developfrom Sep 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where issues without a defined priority would cause exceptions when generating console reports. The fix involves updating the switch expressions to handle unknown/undefined priorities gracefully instead of throwing exceptions.
Key Changes
- Replace exception-throwing default cases with safe fallback values in priority-to-color mappings
- Add test coverage for issues with and without explicit priorities
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Cake.Issues.Reporting.Console/IssueDiagnostic.cs | Updated switch expressions to handle undefined priorities with fallback colors instead of throwing exceptions |
| src/Cake.Issues.Reporting.Console.Tests/ConsoleIssueReportGeneratorTests.cs | Added test cases to verify reporting works for issues both with and without explicit priorities |
f3282d7 to
c9915b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes reporting of issues without a priority to console report