Fix filtering of issues without existing files#1242
Merged
pascalberger merged 5 commits intocake-contrib:developfrom Sep 3, 2025
Merged
Fix filtering of issues without existing files#1242pascalberger merged 5 commits intocake-contrib:developfrom
pascalberger merged 5 commits intocake-contrib:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Console issue report generator where the wrong variable was being used to calculate and log the number of filtered issues. The fix ensures accurate reporting of how many issues were filtered out because they don't have file paths or their files don't exist.
- Fixed variable reference in filtering count calculation for diagnostic logging
- Added comprehensive test coverage for the filtering behavior with three test scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cake.Issues.Reporting.Console/ConsoleIssueReportGenerator.cs | Fixed variable name from enumeratedIssues to diagnosticIssues for accurate filtering count |
| src/Cake.Issues.Reporting.Console.Tests/ConsoleIssueReportGeneratorTests.cs | Added test class with three tests covering filtering scenarios and helper method for file path detection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes filtering of issues without file path or where file does not exists for diagnostics output in Console report format