Skip to content

Update to Cake 2.0#80

Merged
nils-a merged 7 commits intocake-contrib:developfrom
twenzel:feature/UpdateToCake2.0
Dec 7, 2021
Merged

Update to Cake 2.0#80
nils-a merged 7 commits intocake-contrib:developfrom
twenzel:feature/UpdateToCake2.0

Conversation

@twenzel
Copy link
Copy Markdown
Contributor

@twenzel twenzel commented Dec 6, 2021

  • Update to use Cake 2.0
  • Support Cake 2.0 as well as .NET 6
  • Update to use VS 2022 build image

Fixes #78, #77, #79, #76

nils-a
nils-a requested changes Dec 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
You can, however, drop the net461 and netstandard2.0 TFMs. Cake 2.0 dropped support for those.

@augustoproiete augustoproiete linked an issue Dec 6, 2021 that may be closed by this pull request
Update Cake.FileHelpers add-in to target Cake v2.0.0 #79
Closed
This was referenced Dec 6, 2021
Closed
Closed
Closed
augustoproiete
augustoproiete requested changes Dec 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Same comments as @nils-a + .NET 6 SDK install needed

@twenzel
Copy link
Copy Markdown
Contributor Author

twenzel commented Dec 6, 2021

.NET 6 SDK is already installed because appveyor uses the Visual Studio 2022 image.

@twenzel
Copy link
Copy Markdown
Contributor Author

twenzel commented Dec 6, 2021

@augustoproiete Should I update the Github 'Build' action and use the setup-dotnet task to ensure .NET 6 SDK is installed?

@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Dec 6, 2021

.NET 6 SDK is already installed because appveyor uses the Visual Studio 2022 image.

You're correct, except that this project no longer seems to be using AppVeyor for builds... Instead builds are using GitHub actions, so .NET 6 install should be here: https://github.com/cake-contrib/Cake.FileHelpers/blob/4.0.1/.github/workflows/build.yml

Example from @nils-a https://github.com/cake-contrib/Cake.ExtendedNuGet/blob/5.0.0/.github/workflows/build.yml#L31-L38

@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Dec 6, 2021

@augustoproiete Should I update the Github 'Build' action and use the setup-dotnet task to ensure .NET 6 SDK is installed?

Yes, please 😄

augustoproiete
augustoproiete requested changes Dec 7, 2021
View reviewed changes
@augustoproiete augustoproiete self-requested a review December 7, 2021 00:33
augustoproiete
augustoproiete previously approved these changes Dec 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete requested a review from nils-a December 7, 2021 00:33
nils-a
nils-a previously approved these changes Dec 7, 2021
View reviewed changes
@nils-a nils-a dismissed stale reviews from augustoproiete and themself via 315f75c December 7, 2021 10:48
@nils-a nils-a force-pushed the feature/UpdateToCake2.0 branch from 2e3d6cf to 315f75c Compare December 7, 2021 10:48
@nils-a nils-a enabled auto-merge December 7, 2021 10:48
@nils-a nils-a merged commit eac2316 into cake-contrib:develop Dec 7, 2021
@nils-a
Copy link
Copy Markdown
Contributor

nils-a commented Dec 7, 2021

@twenzel your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nils-a nils-a nils-a approved these changes

@augustoproiete augustoproiete augustoproiete left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Cake.FileHelpers add-in to target Cake v2.0.0

3 participants

@twenzel @augustoproiete @nils-a