Skip to content

Bump Cake.Core reference for Cake 3.0.0 release.#111

Merged
nils-a merged 2 commits intocake-contrib:developfrom
squid-box:GH-110
Nov 18, 2022
Merged

Bump Cake.Core reference for Cake 3.0.0 release.#111
nils-a merged 2 commits intocake-contrib:developfrom
squid-box:GH-110

Conversation

@squid-box
Copy link
Copy Markdown
Contributor

Description

Simple update of Cake.Core reference with related dependencies.

Related Issue

This fixes the reported bug #110.

Motivation and Context

This will remove the warnings when using Cake.FileHelpers from Cake 3.0.0+

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@squid-box
Copy link
Copy Markdown
Contributor Author

Hmm, I might need some guidance on the build error. I'm not sure if I need to bump the Cake version used to build (0.38.5 is mildly outdated) or if it's a CI environment problem (never tried building against .NET7 in Ubuntu...

@nils-a
Copy link
Copy Markdown
Contributor

nils-a commented Nov 17, 2022

Hey @squid-box thanks for helping on this. This should be the missing net7.0 sdk.

(The older Cake version used in CI here is due to the usage of an older version of Cake.Recipe.)

Copy link
Copy Markdown
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nils-a nils-a linked an issue Nov 18, 2022 that may be closed by this pull request
@nils-a nils-a merged commit 5e7e847 into cake-contrib:develop Nov 18, 2022
@squid-box squid-box deleted the GH-110 branch November 18, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Cake.Core reference following Cake 3.0.0 release

3 participants