Skip to content

Update README: Replace Gitter with GitHub Discussions#134

Merged
AdmiringWorm merged 1 commit into
cake-contrib:developfrom
augustoproiete-forks:update-readme-gh-discussions
Feb 13, 2021
Merged

Update README: Replace Gitter with GitHub Discussions#134
AdmiringWorm merged 1 commit into
cake-contrib:developfrom
augustoproiete-forks:update-readme-gh-discussions

Conversation

@augustoproiete

Copy link
Copy Markdown
Member

Resolves #132

@codecov

codecov Bot commented Jan 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #134 (f03b573) into develop (471ee3a) will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
- Coverage    96.42%   95.53%   -0.90%     
===========================================
  Files            4        4              
  Lines          112      112              
  Branches        17       17              
===========================================
- Hits           108      107       -1     
- Misses           1        2       +1     
  Partials         3        3              
Impacted Files Coverage Δ
Source/Cake.Codecov/Internals/PlatformDetector.cs 50.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471ee3a...f03b573. Read the comment docs.

@AdmiringWorm AdmiringWorm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why the build failed (the failure of the linter is unrelated though)

@AdmiringWorm AdmiringWorm added this to the vNext milestone Feb 13, 2021
@AdmiringWorm AdmiringWorm merged commit 1721427 into cake-contrib:develop Feb 13, 2021
@mergify

mergify Bot commented Feb 13, 2021

Copy link
Copy Markdown
Contributor

Thank you for your contribution, if you haven't already then feel free to add yourself as a contributors through the all-contributors bot. See https://allcontributors.org/docs/en/bot/usage for more information.

@AdmiringWorm

Copy link
Copy Markdown
Member

@augustoproiete your changes have been merged, thanks for your contribution 👍

@augustoproiete augustoproiete deleted the update-readme-gh-discussions branch February 13, 2021 04:34
@allcontributors

Copy link
Copy Markdown
Contributor

@augustoproiete

I've put up a pull request to add @augustoproiete! 🎉

@cake-contrib-bot

Copy link
Copy Markdown

🎉 This issue has been resolved in version 1.0.0 🎉

The release can be downloaded from:

Your friendly GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Gitter with GitHub Discussions

3 participants