Fix namespace for types in Cake.GitLabCI.Module#190
Merged
nils-a merged 1 commit intocake-contrib:developfrom Feb 19, 2024
Merged
Fix namespace for types in Cake.GitLabCI.Module#190nils-a merged 1 commit intocake-contrib:developfrom
nils-a merged 1 commit intocake-contrib:developfrom
Conversation
3f68217 to
e758601
Compare
When the GitLab CI module was introduced initially, the types were placed in the 'Cake.AzurePipelines.Module' namespace by accident. To fix this and make the namespaces consistent with the package and assembly structure, move all types to the 'Cake.GitLabCI.Module' namespace. While this is a breaking change, the impact is mitigated in two ways: - Builds using the Cake scripting runner automatically discover modules by looking for the 'CakeModule' attribute. The change should thus be transparent to these projects - For Cake.Frosting based builds, a second "GitLabCIModule" type is kept in the Cake.AzurePipelines.Module namespace so the module should be source-compatible with earlier versions The GitLabCIModule in Cake.AzurePipelines.Module was marked as obsolete to discourage usage.
e758601 to
23257ef
Compare
nils-a
approved these changes
Feb 19, 2024
Contributor
|
@ap0llo your changes have been merged, thanks for your contribution 👍 |
|
🎉 This issue has been resolved in version 7.0.0 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the GitLab CI module was introduced initially (see !165), the types were placed in the 'Cake.AzurePipelines.Module' namespace by accident.
To fix this and make the namespaces consistent with the package and assembly structure, move all types to the 'Cake.GitLabCI.Module' namespace.
While this is a breaking change, the impact is mitigated in two ways:
The GitLabCIModule in Cake.AzurePipelines.Module was marked as obsolete to discourage usage.