Fix FormatException in GitLabCILog when log message contains curly braces#189
Merged
nils-a merged 1 commit intocake-contrib:developfrom Feb 16, 2024
Conversation
…aces Adjust call to IConsole.WriteLine() / IConsole.WriteErrorLine() in GitLabCILog to avoid that the log message is interpreted as format string.
f589b29 to
745189d
Compare
nils-a
approved these changes
Feb 16, 2024
Contributor
nils-a
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for getting this fixed!
|
🎉 This issue has been resolved in version 7.0.0 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust call to IConsole.WriteLine() / IConsole.WriteErrorLine() in GitLabCILog to avoid that the log message is interpreted as format string.
Before, the following log call would throw a FormatException when runnign on GitLab CI: