Skip to content

Update dependency to Cake 3#139

Merged
nils-a merged 4 commits intocake-contrib:developfrom
bdukes:cake-3
Aug 30, 2023
Merged

Update dependency to Cake 3#139
nils-a merged 4 commits intocake-contrib:developfrom
bdukes:cake-3

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Jun 12, 2023

I've tested that these changes allow our build to work successfully when targeting Cake 3. Thanks!

@nils-a nils-a linked an issue Aug 26, 2023 that may be closed by this pull request
@nils-a
Copy link
Copy Markdown
Contributor

nils-a commented Aug 26, 2023

@bdukes Thank you for getting this done. Are you in a position to rebase this PR?

Copy link
Copy Markdown
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Aug 30, 2023

I've rebased my branch, let me know if there's anything else I can do. Thanks!

@nils-a nils-a merged commit 869c43e into cake-contrib:develop Aug 30, 2023
@nils-a
Copy link
Copy Markdown
Contributor

nils-a commented Aug 30, 2023

@bdukes your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start supporting Cake 3.0.0

2 participants