Skip to content

(#114) added Cake.GitHubActions.Module#115

Merged
gep13 merged 1 commit intocake-contrib:developfrom
nils-a:feature/GH-114
Nov 21, 2022
Merged

(#114) added Cake.GitHubActions.Module#115
gep13 merged 1 commit intocake-contrib:developfrom
nils-a:feature/GH-114

Conversation

@nils-a
Copy link
Copy Markdown
Contributor

@nils-a nils-a commented Jan 4, 2022

Implemented grouping in GH-Actions, as well as
error and warning logs.

fixes #114

@nils-a nils-a requested review from augustoproiete and gep13 January 4, 2022 21:48
@nils-a nils-a force-pushed the feature/GH-114 branch 2 times, most recently from fc4b738 to 9508905 Compare August 11, 2022 08:30
Copy link
Copy Markdown
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Copy Markdown
Member

gep13 commented Nov 15, 2022

@nils-a apologies about not getting to this sooner, completely fell off the radar!

This looks really good to me! Is there anything that would stop us getting a new release of this out the door?

There is something that I would like to get added to this Module, based on the new functionality in Cake v3.0.0, but I would see this coming out in a new version, once we ship this initial release of this functionality.

Implemented grouping in GH-Actions, as well as
error and warning logs.
@gep13 gep13 merged commit eee3b30 into cake-contrib:develop Nov 21, 2022
@gep13
Copy link
Copy Markdown
Member

gep13 commented Nov 21, 2022

@nils-a thank you very much for getting this added!

@nils-a nils-a deleted the feature/GH-114 branch May 1, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Better logging and grouping in GitHub Actions

2 participants