Skip to content

Add grouping for tasks in AzureDevOps pipeline#112

Merged
nils-a merged 4 commits intocake-contrib:developfrom
JuergenRB:feature/AddAzurePipelinesExecutionStrategyForGrouping
Jan 4, 2022
Merged

Add grouping for tasks in AzureDevOps pipeline#112
nils-a merged 4 commits intocake-contrib:developfrom
JuergenRB:feature/AddAzurePipelinesExecutionStrategyForGrouping

Conversation

@JuergenRB
Copy link
Copy Markdown
Contributor

Closes #111

@nils-a
Copy link
Copy Markdown
Contributor

nils-a commented Dec 29, 2021

@JuergenRB Thanks for the PR!
May I ask, what was the reasoning for implementing an IExecutionStrategy instead of doing this in the existing AzurePipelinesEngine?

The TeamCityEngine provides "groups" very similar to what was done here (see #101), but that is all based on the existing events provided by ICakeEngine. Am I missing something?

@JuergenRB
Copy link
Copy Markdown
Contributor Author

@nils-a
My idea was not to have duplicate task titles in the log output.
That's why I implemented it in IExecutionStrategy .

If you want, I can rebuild it so that it is solved in a consistent way.

@nils-a
Copy link
Copy Markdown
Contributor

nils-a commented Dec 30, 2021

@JuergenRB yes, having the functionality consistent would be good.

@JuergenRB
Copy link
Copy Markdown
Contributor Author

Changed
image

Copy link
Copy Markdown
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. One small change, though.

Copy link
Copy Markdown
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nils-a nils-a enabled auto-merge January 4, 2022 08:11
@nils-a nils-a merged commit 9f83f03 into cake-contrib:develop Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add grouping for tasks in AzureDevOps pipeline

2 participants