Merged
Conversation
josuave
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently Windows has been packaging some inbox win32 apps such as Notepad and Paint, so we are launching them via AppUserModelId. However, the way we did this required explorer.exe to be running, even though these apps can run just fine without explorer.
This changes apps known to launch without explorer (Edge PWAs and FullTrust apps) to use the new activation method exposed by ManagedShell, so now they can launch without explorer. This doesn't change anything for sandboxed apps such as Calculator.
The reason sandboxed apps are still launched using the old method that requires explorer: Sandboxed apps still require explorer to run anyway, and app activation APIs hang for quite some time when trying to launch them, so the old method ultimately works better.
This fixes #734 which specifically mentions Edge PWAs.