Skip to content

Use repr(C) in RTS struct#2788

Merged
mergify[bot] merged 3 commits intomasterfrom
osa1/struct_repr_again
Sep 16, 2021
Merged

Use repr(C) in RTS struct#2788
mergify[bot] merged 3 commits intomasterfrom
osa1/struct_repr_again

Conversation

@osa1
Copy link
Copy Markdown
Contributor

@osa1 osa1 commented Sep 16, 2021

See the node added with this commit and
#2761 (comment) for
the problem this solves.

See the node added with this commit and
#2761 (comment) for
the problem this solves.
@osa1 osa1 requested review from crusso, ggreif and nomeata September 16, 2021 11:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 16, 2021

Comparing from 9b24b7b to 8e224f5:
In terms of gas, 1 tests regressed and the mean change is +0.0%.
In terms of size, 3 tests improved and the mean change is -0.0%.

Comment thread rts/motoko-rts/src/types.rs Outdated
Copy link
Copy Markdown
Contributor

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for a great note

@osa1 osa1 added the automerge-squash When ready, merge (using squash) label Sep 16, 2021
@mergify mergify bot merged commit a71a21b into master Sep 16, 2021
@mergify mergify bot deleted the osa1/struct_repr_again branch September 16, 2021 15:18
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants