Merged
Conversation
to include the patch we tried in #2542
This was referenced Jun 19, 2021
osa1
approved these changes
Jun 19, 2021
Contributor
Author
|
I can no longer see the hydra logs, so you’ll have to debug this on your own (until we have #2565, which I can’t quite tell how fast it’ll be) |
Contributor
|
Every failure (there are many) like |
4707334 to
673d7b3
Compare
|
In terms of gas, no changes are observed in 3 tests. |
Contributor
Author
|
Looks good. Can be merged once hydra has caught up, or after removing hydra :-) |
Contributor
Contributor
Author
|
Looks like hydra doesn't like this. Anybody know why? Or we just ignore it, and merge this after #2748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to include the patch we tried in #2542