Skip to content

ci: remove android and plan9 from cross-build workflow#6268

Merged
mholt merged 3 commits intomasterfrom
remove-unsupported-geese
Apr 24, 2024
Merged

ci: remove android and plan9 from cross-build workflow#6268
mholt merged 3 commits intomasterfrom
remove-unsupported-geese

Conversation

@mohammed90
Copy link
Member

@mohammed90 mohammed90 commented Apr 24, 2024

We added the cross-build flows to track Caddy build-ability across the known operating systems, hoping we'd be able to support them all eventually. We managed to resolve the issue for AIX by building with nobadger build tag (grrr Badger!). Plan9 build is still blocked due to dependencies. Android build requires cgo. We give up on plan9. Android has the workaround of using Termux with proot/chroot. We closed #3615.

This PR is to remove the geese we no longer are interested in supporting. I also turned the warnings into failures because now we want to know for sure if any of them fails. The final list of tested geese is:

  • aix
  • linux
  • solaris
  • illumos
  • dragonfly
  • freebsd
  • openbsd
  • windows
  • darwin
  • netbsd

@mohammed90 mohammed90 added the CI/CD 🔩 Automated tests, releases label Apr 24, 2024
@mholt
Copy link
Member

mholt commented Apr 24, 2024

This PR is to remove the geese

Amazing obscure reference to the Go standard lib.

I'll work on that lint error...

@mholt
Copy link
Member

mholt commented Apr 24, 2024

Obviously the linter error is unrelated to your PR, but as I'm investigating, it's a false positive?

I run this locally in the caddytls folder:

gci list . --skip-generated -s standard -s default -s "prefix(github.com/caddyserver/caddy/v2/cmd)" -s "prefix(github.com/caddyserver/caddy)" --custom-order

And I get no output. Same result for gci diff acmeissuer.go with the same flags.

@francislavoie
Copy link
Member

francislavoie commented Apr 24, 2024

As a Canadian, I approve of the removal of geese

image

@mohammed90
Copy link
Member Author

mohammed90 commented Apr 24, 2024 •
edited
Loading

Obviously the linter error is unrelated to your PR, but as I'm investigating, it's a false positive?

I run this locally in the caddytls folder:

gci list . --skip-generated -s standard -s default -s "prefix(github.com/caddyserver/caddy/v2/cmd)" -s "prefix(github.com/caddyserver/caddy)" --custom-order

And I get no output. Same result for gci diff acmeissuer.go with the same flags.

I'll push the fix PR. One sec... #6270

@mholt
Copy link
Member

mholt commented Apr 24, 2024

Wow, thanks -- that was fast.

@francislavoie HONK 🦆

@mholt mholt enabled auto-merge (squash) April 24, 2024 21:18
@mohammed90
Copy link
Member Author

mohammed90 commented Apr 24, 2024

As a Canadian, I approve of the removal of geese

Can you please make it an approval GitHub recognizes? 🤣

@mholt mholt merged commit 4d6370b into master Apr 24, 2024
@mholt mholt deleted the remove-unsupported-geese branch April 24, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francislavoie francislavoie francislavoie approved these changes

Assignees

No one assigned

Labels

CI/CD 🔩 Automated tests, releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Caddy Build Fails for Solaris/Illumos and Plan9

3 participants

@mohammed90 @mholt @francislavoie