caddyconfig: Error on extra args for route and handle directive family#3740
Merged
mholt merged 1 commit intocaddyserver:masterfrom Sep 21, 2020
Merged
caddyconfig: Error on extra args for route and handle directive family#3740mholt merged 1 commit intocaddyserver:masterfrom
mholt merged 1 commit intocaddyserver:masterfrom
Conversation
mholt
approved these changes
Sep 21, 2020
Member
mholt
left a comment
There was a problem hiding this comment.
Thanks, I think this should even go in 2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought up here: https://caddy.community/t/v2-how-do-i-selectively-rewrite-multiple-times/9854
Basically, this disallows extra args on the line after the matcher for
route,handle,handle_errorsandhandle_path. For example, these are now errors:This is purely an adapter change to be stricter so that users don't have args in their config that do nothing useful (like thinking some args act like a matcher).