fix typo in github_access_token option#153
Merged
domenkozar merged 1 commit intocachix:masterfrom Jan 19, 2023
Merged
Conversation
add_config only takes one argument; this was causing Nix to error with "illegal configuration line 'access-tokens' in '/etc/nix/nix.conf'"
Member
|
Documenting this would be great :) |
Contributor
Author
|
Okay, I made #156 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_configonly takes one argument, not two. This will cause an error when usinggithub_access_token:This should (hopefully) fix that. On a sort of related note, the token passed to
github_access_tokenwill be overwritten if the user also includesaccess-tokens = ...inextra_nix_config(instead of merging the two); would it be worth making a PR to document this behavior in the README?