Skip to content

add github_access_token option#152

Merged
domenkozar merged 1 commit intocachix:masterfrom
zimbatm:github-access-token
Dec 30, 2022
Merged

add github_access_token option#152
domenkozar merged 1 commit intocachix:masterfrom
zimbatm:github-access-token

Conversation

@zimbatm
Copy link
Copy Markdown
Contributor

@zimbatm zimbatm commented Dec 27, 2022

I'm starting to see rate limit issues with GitHub Actions more
frequently so I propose to make this option more readily available.

@zimbatm
Copy link
Copy Markdown
Contributor Author

zimbatm commented Dec 27, 2022

before I go and fix the CI issues, what do you think, is it worth the extra complexity?

@domenkozar
Copy link
Copy Markdown
Member

Happy to merge this if CI passes :)

@zimbatm zimbatm force-pushed the github-access-token branch 2 times, most recently from 1286288 to b588e45 Compare December 29, 2022 22:24
I'm starting to see rate limit issues with GitHub Actions more
frequently so I propose to make this option more readily available.
@zimbatm zimbatm force-pushed the github-access-token branch from b588e45 to c04fcbc Compare December 29, 2022 22:28
@zimbatm
Copy link
Copy Markdown
Contributor Author

zimbatm commented Dec 29, 2022

I think it's fixed but there is an issue with nix profiles

@domenkozar domenkozar merged commit b15708f into cachix:master Dec 30, 2022
@zimbatm zimbatm deleted the github-access-token branch December 30, 2022 19:00
@zimbatm zimbatm restored the github-access-token branch December 30, 2022 19:00
@zimbatm zimbatm deleted the github-access-token branch December 30, 2022 19:00
@zimbatm zimbatm restored the github-access-token branch December 30, 2022 19:00
@NickHu
Copy link
Copy Markdown

NickHu commented Jan 4, 2023

Would love to see a new release for this action, so I can more readily use it, as I'm seeing the same issues! Thanks for your contribution!

@domenkozar
Copy link
Copy Markdown
Member

Couldn't we just set it by default?

@zimbatm
Copy link
Copy Markdown
Contributor Author

zimbatm commented Jan 4, 2023

AFAIK secrets.GITHUB_TOKEN has to be passed explicitly. But this could become the default example in the README and nix.dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants