Merged
Conversation
On error, just mark the error with `core.setFailed`, this is enough to kill the process. Replace child_process.execFileSync with '@actions/exec'.exec to be async all the way.
Contributor
Author
|
A good follow-up would be to clean the error reported by the cachix CLI so that it's not just a pretty-printed object. |
domenkozar
requested changes
Jan 3, 2021
dist/main/index.js
Outdated
| } | ||
| function upload() { | ||
| return __awaiter(this, void 0, void 0, function* () { | ||
| core.startGroup('Cachix: upload'); |
Member
There was a problem hiding this comment.
Not sure about this: I wouldn't expect Upload to be logged when it's not uploading (also it's called pushing)
Contributor
Author
There was a problem hiding this comment.
The issue I was trying to avoid is core.stopGroup not being called on exception.
I'm thinking of this as a category, and then the actions inside would vary if there is something to upload or not. I could rename it push so it doesn't sound like it's actually pushing?
Contributor
Author
There was a problem hiding this comment.
Renamed to Cachix: push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On error, just mark the error with
core.setFailed, this is enough tokill the process (apparently).
Replace
child_process.execFileSyncwith'@actions/exec'.execto be asyncall the way and remove the
UnhandledPromiseRejectionWarningbacktrace.Before:
After:
