refactor: modify the init logic for env tag options to make it more r…#347
Merged
caarlos0 merged 1 commit intocaarlos0:mainfrom Dec 6, 2024
astak16:main
Merged
refactor: modify the init logic for env tag options to make it more r…#347caarlos0 merged 1 commit intocaarlos0:mainfrom astak16:main
caarlos0 merged 1 commit intocaarlos0:mainfrom
astak16:main
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 628 625 -3
=========================================
- Hits 628 625 -3 ☔ View full report in Codecov by Sentry. |
Owner
|
this looks great, thanks @astak16! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The init for env tag options should handle uninitialized pointers, and using reflect.Invalid for the check would be more reasonable.