Skip to content

Added EditorConfig#327

Merged
caarlos0 merged 11 commits intocaarlos0:mainfrom
BorzdeG:add-editorconfig
Oct 8, 2024
Merged

Added EditorConfig#327
caarlos0 merged 11 commits intocaarlos0:mainfrom
BorzdeG:add-editorconfig

Conversation

@BorzdeG
Copy link
Copy Markdown
Contributor

@BorzdeG BorzdeG commented Aug 22, 2024 •
edited
Loading

  1. Added EditorConfig
  2. Fixed the text formatting in the README
  3. Added revive linter
  4. Visual setting for IntelligJ IDE, no consequences on code validation
  5. Create issue Rename EnvVarIsNotSetError to VarIsNotSetError #328

@BorzdeG
1. Added [EditorConfig](https://editorconfig.org/)
dd311b9 
1. Fixed the text formatting in the README
@BorzdeG BorzdeG mentioned this pull request Aug 22, 2024
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (84c7739) to head (84a2f9b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #327   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          512       517    +5     
=========================================
+ Hits           512       517    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ccoVeille
ccoVeille reviewed Aug 22, 2024
View reviewed changes
@BorzdeG BorzdeG marked this pull request as draft August 22, 2024 11:22
@ccoVeille
Copy link
Copy Markdown

ccoVeille commented Aug 22, 2024

You are facing the line length nightmare

I did too with one of my project.

https://github.com/ccoVeille/golangci-lint-config-examples/blob/main/.editorconfig

Good luck, have fun 😅

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 22, 2024
@BorzdeG BorzdeG requested a review from ccoVeille August 22, 2024 12:33
@BorzdeG BorzdeG marked this pull request as ready for review August 22, 2024 12:33
ccoVeille
ccoVeille reviewed Aug 22, 2024
View reviewed changes
@ccoVeille ccoVeille mentioned this pull request Aug 22, 2024
Closed
ccoVeille
ccoVeille reviewed Aug 22, 2024
View reviewed changes
@BorzdeG BorzdeG requested a review from ccoVeille August 22, 2024 17:37
ccoVeille
ccoVeille suggested changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the previously discussed points that I'm adding back again

@ccoVeille
Copy link
Copy Markdown

ccoVeille commented Aug 22, 2024

Thanks for baring with me, my feedbacks, and my iterative comments

LGTM 👍

@ccoVeille ccoVeille mentioned this pull request Aug 23, 2024
Merged
caarlos0
caarlos0 reviewed Aug 24, 2024
View reviewed changes
@BorzdeG BorzdeG requested a review from caarlos0 August 25, 2024 07:07
@caarlos0 caarlos0 merged commit b76caa9 into caarlos0:main Oct 8, 2024
@caarlos0
Copy link
Copy Markdown
Owner

caarlos0 commented Oct 8, 2024

thanks!

@BorzdeG BorzdeG deleted the add-editorconfig branch October 9, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caarlos0 caarlos0 Awaiting requested review from caarlos0

1 more reviewer

@ccoVeille ccoVeille ccoVeille approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BorzdeG @ccoVeille @caarlos0