Conversation
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
|
Well, the good thing is that it also reduces 3x the compute required for CI |
Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
(Narrator: That wasn't it.)
|
c-cube
left a comment
There was a problem hiding this comment.
Interesting. I wonder if git subtree should be used instead of git submodule, mostly for questions of whether it's doable to opam pin this repo? And how hard it is to do releases.
| @@ -0,0 +1,5 @@ | |||
| (copy_files %{project_root}/submodules/ocaml-lsp/jsonrpc/src/*.{ml,mli}) | |||
There was a problem hiding this comment.
oh that's neat, ok, that's how you avoid the clash with the actual lsp library.
|
Merged by hand with some additional fixes, thanks! I also just inlined the |
|
Thank you for merging! Regarding |
|
Very interesting, thanks for the elaboration. I guess that since dune is
still experimental on that front, there's no harm in using submodules
for now!
|
|
@c-cube Using git subtree fixed the dune package management issue :) |
|
excellent! |
Resolves #48
Ok so this took me quite some time, but it was just a matter of finding the correct dune invocations. I also thought a lot of renaming would be required, but in the end, not so much.
Updating lsp/jsonrpc
Depending on how much lsp and jsonrpc change, there might none to some work required updating linol's own dependencies and version of the dune file required to build lsp and
Breaking changes
If someone currently calls
LsporJsonrpcdirectly to use withLinol, this update would break their code. But it would trivially be fixed by using-open Linol.Importin their flags, or just useopen Linol.Importin the relevant filesTesting
I tested this by pinning the commit to my project that uses it, and it just updated seamlessly :) I could also upgrade ocaml-lsp, and it doesn't interfere with linol