update ui and add output #459
Conversation
rvolosatovs
left a comment
There was a problem hiding this comment.
A successful set should not produce any output, but once error handling is wired up we'd want to print the error if it occurred (i.e.
wrpc/examples/web/rust/index.html
Lines 217 to 220 in 6a79943
1, then what follows is:
- LEB-128 encoded uint32 (decoding in Rust: https://github.com/wrpc/wasm-tokio/blob/b245de13b716350faafc346d0516a8f40742508a/leb128-tokio/src/lib.rs#L127-L147)
- UTF-8 encoded string
A little trick, however, is that for cases where LEB-128 encoded uint value is below 128, it is equal to a byte u8 repr of the value. (so for each i where i < 127, encoding is just i).
For now we could just read the whole buffer and if it's length is 128 or lower, skip the first byte and print the rest as a UTF-8 encoded string. You can see an example of that in decoding of set result
Just an idea for a potential follow-up (which I will try to work on myself anyway at some point)
LGTM, thanks!
|
For reference, the string encoding is formally defined here: https://webassembly.github.io/spec/core/binary/values.html#names |
No description provided.