Skip to content

fix(wit-bindgen-go): Add missing 'instance' key to slog statements #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rvolosatovs merged 1 commit into from
Sep 13, 2024
Merged

fix(wit-bindgen-go): Add missing 'instance' key to slog statements #321

rvolosatovs merged 1 commit into from
Sep 13, 2024

Conversation

@joonas
Copy link
Contributor

@joonas joonas commented Sep 13, 2024 •
edited
Loading

While generating bindings I was greeted with a bunch of warnings about missing keys, so this adds theinstance key to the places where it was missing:

bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:639:123: slog.WarnContext arg "err" should be a string or a slog.Attr (possible missing key or value)
bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:648:109: slog.WarnContext arg "err" should be a string or a slog.Attr (possible missing key or value)
bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:655:128: slog.ErrorContext arg "err" should be a string or a slog.Attr (possible missing key or value)
bindings/exports/wrpc/keyvalue/store/bindings.wrpc.go:662:141: slog.WarnContext arg "err" should be a string or a slog.Attr (possible missing key or value)
...

fix(wit-bindgen-go): Add missing 'instance' key to slog statements
3731234 
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
@joonas joonas requested a review from rvolosatovs as a code owner September 13, 2024 21:35
@rvolosatovs
Copy link
Member

rvolosatovs commented Sep 13, 2024

Thanks!

@rvolosatovs rvolosatovs added this pull request to the merge queue Sep 13, 2024
Merged via the queue into bytecodealliance:main with commit 67fc056 Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joonas @rvolosatovs