feat(transport): Adds support for a vec of options #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered this when trying to implement `wasi:keyvalue/batch`, which returns a list of optionals. There was no `Deferred` impl for an option decoder, so this adds a simple implementation for it Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
Contributor
Author
|
This is in draft until it can pick up on wrpc/wasm-tokio#1 when it merges and updates |
rvolosatovs
reviewed
Sep 13, 2024
| impl_deferred_sync!(CoreVecDecoder<Leb128DecoderU128>); | ||
| impl_deferred_sync!(CoreVecDecoder<UnitCodec>); | ||
|
|
||
| impl<T, W> Deferred<T> for CoreVecDecoder<OptionDecoder<W>> |
Member
There was a problem hiding this comment.
This is not quite right, since it would discard the async value for all option<stream<T>>, option<future<T>> or nested async values (e.g. option of a record, which contains a field of future<T> type)
rvolosatovs
reviewed
Sep 13, 2024
Member
rvolosatovs
left a comment
There was a problem hiding this comment.
The issue here seems to be that the wrong decoder is used for options and results, I've fixed that in #318, could you confirm that it fixes your issue?
Contributor
Author
|
Yep, looks like #318 fixed it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this when trying to implement
wasi:keyvalue/batch, which returns a list of optionals. There was noDeferredimpl for an option decoder, so this adds a simple implementation for it