Skip to content

winch: Minor improvements to fuel check#9750

Merged
saulecabrera merged 1 commit intobytecodealliance:mainfrom
saulecabrera:winch-minor-improvements-to-fuel-checks
Dec 6, 2024
Merged

winch: Minor improvements to fuel check#9750
saulecabrera merged 1 commit intobytecodealliance:mainfrom
saulecabrera:winch-minor-improvements-to-fuel-checks

Conversation

@saulecabrera
Copy link
Copy Markdown
Member

This commits ports the suggestions made in #9737 to fuel checks.

Namely

  • Prefer the usage of *_reg over *_var
  • Add a couple of disassembly tests

@saulecabrera saulecabrera requested review from a team as code owners December 6, 2024 14:15
@saulecabrera saulecabrera requested review from alexcrichton and cfallin and removed request for a team December 6, 2024 14:15
@saulecabrera saulecabrera force-pushed the winch-minor-improvements-to-fuel-checks branch from f010571 to 0713fbc Compare December 6, 2024 14:28
@github-actions github-actions bot added the winch Winch issues or pull requests label Dec 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 6, 2024

Subscribe to Label Action

cc @saulecabrera

Details This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This commits ports the suggestions made in bytecodealliance#9737
to fuel checks.

Namely

* Prefer the usage of `*_reg` over `*_var`
* Add a couple of disassembly tests
@saulecabrera saulecabrera force-pushed the winch-minor-improvements-to-fuel-checks branch from 0713fbc to 40328eb Compare December 6, 2024 18:34
@saulecabrera saulecabrera added this pull request to the merge queue Dec 6, 2024
Merged via the queue into bytecodealliance:main with commit 7145ca5 Dec 6, 2024
@saulecabrera saulecabrera deleted the winch-minor-improvements-to-fuel-checks branch December 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

winch Winch issues or pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants