Simplify some trap handling in wasmtime runtime#9673
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Nov 25, 2024
Merged
Simplify some trap handling in wasmtime runtime#9673alexcrichton merged 1 commit intobytecodealliance:mainfrom
wasmtime runtime#9673alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
The `needs_backtrace` field on `TrapReason` is an old artifact of having the `wasmtime` and `wasmtime-runtime` crates split and there's no longer any need for that. This commit removes the field and directly queries it from the error as necessary when capturing backtraces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
needs_backtracefield onTrapReasonis an old artifact of having thewasmtimeandwasmtime-runtimecrates split and there's no longer any need for that. This commit removes the field and directly queries it from the error as necessary when capturing backtraces.