Remove the wasmtime_environ::MemoryPlan type#9532
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Oct 31, 2024
Merged
Remove the wasmtime_environ::MemoryPlan type#9532alexcrichton merged 2 commits intobytecodealliance:mainfrom
wasmtime_environ::MemoryPlan type#9532alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This is the equivalent of bytecodealliance#9530 for memories. The goal of this commit is to eventually remove the abstraction layer of `MemoryPlan` and `MemoryStyle` in favor of directly reading the configuration of `Tunables`. The prediction is that it will be simpler to work directly with configured values instead of a layer of abstraction between the configuration and the runtime which needs to be evolved independently to capture how to interpret the configuration. Like with bytecodealliance#9530 my plan is to eventually remove the `MemoryStyle` type itself, but that'll be a larger change, so it's deferred to a future PR.
687fab0 to
a5ae591
Compare
abrown
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the equivalent of #9530 for memories. The goal of this commit is to eventually remove the abstraction layer of
MemoryPlanandMemoryStylein favor of directly reading the configuration ofTunables. The prediction is that it will be simpler to work directly with configured values instead of a layer of abstraction between the configuration and the runtime which needs to be evolved independently to capture how to interpret the configuration.Like with #9530 my plan is to eventually remove the
MemoryStyletype itself, but that'll be a larger change, so it's deferred to a future PR.