Skip to content

Backport 9262 to release-25.0.0#9270

Merged
alexcrichton merged 2 commits intobytecodealliance:release-25.0.0from
elliottt:trevor/backport-9262
Sep 17, 2024
Merged

Backport 9262 to release-25.0.0#9270
alexcrichton merged 2 commits intobytecodealliance:release-25.0.0from
elliottt:trevor/backport-9262

Conversation

@elliottt
Copy link
Copy Markdown
Member

Backport #9262 to the release-25.0.0 branch, and add release notes for the change.

sunfishcode and others added 2 commits September 17, 2024 14:06
…ealliance#9262)

* wit-bindgen: Don't trace values containing lists by default.

`list` values in Wit interfaces can represent things like HTTP bodies
which can be very large. To enable tracing without spamming logfiles
with all this data, put printing of values containing `list`s behind
a separate `verbose_tracing` option.

This is a coarse-grained approach; but it seems like a pretty good
default for tracing, and enabling full tracing when one needs it is
straightforward.

In the future, we may want to refine the option by implementing
the `Valuable` trait and using `tracing::field::valuable`, which
could allow us to do things like print non-`list` fields of records
that otherwise contain `list`s.

* Use `option_type_contains_lists` more.

* Hook up `verbose_tracing` to the macro.

* Update expected outputs for tests.
@elliottt elliottt requested review from a team as code owners September 17, 2024 21:13
@elliottt elliottt requested review from fitzgen and removed request for a team September 17, 2024 21:13
@alexcrichton alexcrichton enabled auto-merge (squash) September 17, 2024 21:22
@alexcrichton alexcrichton merged commit b50bc5e into bytecodealliance:release-25.0.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants