Backport 9224 to release-25#9239
Merged
alexcrichton merged 1 commit intobytecodealliance:release-25.0.0from Sep 13, 2024
Merged
Backport 9224 to release-25#9239alexcrichton merged 1 commit intobytecodealliance:release-25.0.0from
alexcrichton merged 1 commit intobytecodealliance:release-25.0.0from
Conversation
See the comment in the source file, we can't have FORTIFY_SOURCE enabled for longjmp code, so undefine it. See the source for longjmp_chk in glibc, this assertion is fired: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/____longjmp_chk.c;hb=HEAD#l54 Here is a similar commit in glibc tests: https://sourceware.org/git/?p=glibc.git;a=commit;h=46432be2f1d4de962b51ca6b9f80fc37744be9f7
alexcrichton
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #9224 to the release branch. It's a very minor thing that getting out sooner unblocks some build tooling upgrades in Redpanda. Patching on our end would be a bit involved. I didn't add this to release notes because this would only effect C users that are setting rather advanced security parameters.