Implement new *.wast directives in wasmtime-wast#9223
Merged
pchickey merged 4 commits intobytecodealliance:mainfrom Sep 10, 2024
Merged
Implement new *.wast directives in wasmtime-wast#9223pchickey merged 4 commits intobytecodealliance:mainfrom
*.wast directives in wasmtime-wast#9223pchickey merged 4 commits intobytecodealliance:mainfrom
Conversation
This is a follow-up from bytecodealliance#9219 to add support for a few more directives in `*.wast` tests to notably compile a module and possibly instantiate it multiple times. This copies the upstream spec test using these new directives and edits it to remove the unsupported exception-handling bits.
Contributor
|
Looks good, but the component paths aren't exercised in the tests. Is there missing functionality where those can't be exercised yet, or can we add a test for it? |
Member
Author
|
Good point! I've added a small test for components too |
pchickey
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #9219 to add support for a few more directives in
*.wasttests to notably compile a module and possibly instantiate it multiple times.This copies the upstream spec test using these new directives and edits it to remove the unsupported exception-handling bits.