Integrate wasi-runtime-config into wasmtime-cli#8970
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jul 19, 2024
Merged
Integrate wasi-runtime-config into wasmtime-cli#8970alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
tests/all/cli_tests.rs
Outdated
| Ok(()) | ||
| } | ||
|
|
||
| #[cfg(feature = "wasi-runtime-config")] |
Member
There was a problem hiding this comment.
Currently we assume that all features are enabled during testing, so it's ok to drop this and the marker below.
Cargo.toml
Outdated
| winch = ["wasmtime/winch"] | ||
| wmemcheck = ["wasmtime/wmemcheck"] | ||
| memory-protection-keys = ["wasmtime-cli-flags/memory-protection-keys"] | ||
| wasi-runtime-config = ["dep:wasmtime-wasi-runtime-config"] |
Member
There was a problem hiding this comment.
Could this be added to the on-by-default features list? That's generally what we're doing with WASI proposals right now so long as there's no extra build requirements, which this proposal doesn't have.
ac33a7d to
347ad82
Compare
Contributor
Author
|
All comments addressed, PTAL |
alexcrichton
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8929
This patch adds two new flags:
Separating these two flags is considered to handle the scenario where the
wasi-runtime-configAPI is enabled but no configuration needs to be passed.To use the
wasi-runtime-configAPI inwasmtime-cli:wasi-runtime-configAPI support by-Sruntime-config:cc @alexcrichton