Skip to content

Add wasmtime-c-api-impl to the list of crates to publish (#7837)#7872

Merged
elliottt merged 1 commit intobytecodealliance:release-18.0.0from
maxbrunsfeld:backport-public-c-api-to-18.0.0
Feb 6, 2024
Merged

Add wasmtime-c-api-impl to the list of crates to publish (#7837)#7872
elliottt merged 1 commit intobytecodealliance:release-18.0.0from
maxbrunsfeld:backport-public-c-api-to-18.0.0

Conversation

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

This is a backport of #7837 for the v18.0.0 release.

…iance#7837)

* Add wasmtime-c-api-impl to the list of crates to publish

* Enable rustdoc and publishing for c-api crate

* Provide paths to c-api headers as cargo links metadata

* Add a README section about using wasm-c-api in a rust crate

* In C API doc comment, mention use case for crates w/ C bindings

* Enable publishing for wasmtime-c-api-macros (prtest:full)

* Move c-api crates later in the publishing sequence (prtest:full)
@maxbrunsfeld maxbrunsfeld requested review from a team as code owners February 5, 2024 19:20
@maxbrunsfeld maxbrunsfeld requested review from alexcrichton and removed request for a team February 5, 2024 19:20
@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Feb 5, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2024

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@maxbrunsfeld
Copy link
Copy Markdown
Contributor Author

@alexcrichton Looks like this applied cleanly. Thanks for being open to backporting it.

Copy link
Copy Markdown
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Alex already recommended backporting this PR in #7837 (comment) 👍

@elliottt elliottt merged commit 57444d2 into bytecodealliance:release-18.0.0 Feb 6, 2024
@maxbrunsfeld maxbrunsfeld deleted the backport-public-c-api-to-18.0.0 branch February 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants