[9.0.0] Fix support for native profiling#6435
Merged
alexcrichton merged 1 commit intobytecodealliance:release-9.0.0from May 22, 2023
Merged
[9.0.0] Fix support for native profiling#6435alexcrichton merged 1 commit intobytecodealliance:release-9.0.0from
alexcrichton merged 1 commit intobytecodealliance:release-9.0.0from
Conversation
This commit fixes a panic that's easy to hit with native profilers by accident. This was introduced in bytecodealliance#6262 which made it into the 9.0.0 release but is not present on `main` due to the refactorings of bytecodealliance#6361 which are on `main` but not on 9.0.0. Closes bytecodealliance#6433
Member
Author
|
Given how easy it is to trigger this I think it would also be good to have a 9.0.1 point release for this. |
pchickey
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a panic that's easy to hit with native profilers by accident. This was introduced in #6262 which made it into the 9.0.0 release but is not present on
maindue to the refactorings of #6361 which are onmainbut not on 9.0.0.Closes #6433