x64: improve tests for heap_addr#4841
Merged
abrown merged 2 commits intobytecodealliance:mainfrom Sep 1, 2022
Merged
Conversation
This change adds Cranelift `compile` tests for the various cases for `heap_addr`. The idea behind this is to more clearly show what the penalties are for dynamically- vs statically-allocated memory as well as turning Spectre mitigations on and off.
Member
Author
|
I can remove the comments explaining what is going on and store those somewhere else if that is preferable. |
cfallin
approved these changes
Sep 1, 2022
Member
cfallin
left a comment
There was a problem hiding this comment.
Looks good -- thanks for spelling out these cases; it's a useful analysis and we can keep it updated if we come up with better bounds-checking sequences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds Cranelift
compiletests for the various cases forheap_addr. The idea behind this is to more clearly show what thepenalties are for dynamically- vs statically-allocated memory as well as
turning Spectre mitigations on and off.