x64: Finish migrating brz and brnz to ISLE#4614
x64: Finish migrating brz and brnz to ISLE#4614elliottt merged 3 commits intobytecodealliance:mainfrom
Conversation
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
left a comment
There was a problem hiding this comment.
r=me with nitpick below resolved
| ;; A type guard for matching 64-bit sized ints, bools, or references but | ||
| ;; explicitly ruling out 32-bit references. | ||
| (decl ty_int_bool_or_ref () Type) | ||
| (extern extractor ty_int_bool_or_ref ty_int_bool_or_ref) |
There was a problem hiding this comment.
Nitpick: I feel like the name could have 64 in it somewhere since this explicitly doesn't handle 32-bit ints/bools/refs.
There was a problem hiding this comment.
Wait looking at the implementation, this accepts 32-bit ints/bools, jsut not 32-bit refs. Which I think is fine, but I think means the comment here is misleading.
There was a problem hiding this comment.
The function I ported over seemed to accept a pretty wide range of types, definitely open to better naming suggestions :)
Finish migrating the last case for
brzandbrnzlowering to ISLE in the x64 backend.