Port Shuffle to ISLE (AArch64)#4596
Merged
cfallin merged 2 commits intobytecodealliance:mainfrom Aug 4, 2022
Merged
Conversation
cfallin
approved these changes
Aug 3, 2022
Member
cfallin
left a comment
There was a problem hiding this comment.
Thanks! One potential cleanup nit below but otherwise looks good.
The hardcoded register bit is slightly unfortunate but we'd have to come up with some ugly regalloc hacks to do something better here ("adjacent register" constraint) and it's pre-existing, and this is a direct port of what was there already, so nothing wrong with this PR at all. I'll think a bit on this though...
Ported the existing implementation of `Shuffle` for AArch64 to ISLE. Copyright (c) 2022 Arm Limited
Copyright (c) 2022 Arm Limited
b3bcca2 to
33cdd97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported the existing implementation of
Shufflefor AArch64 to ISLE.Copyright (c) 2022 Arm Limited